This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 00/11] Improve generic string routines
- From: Richard Henderson <rth at twiddle dot net>
- To: libc-alpha at sourceware dot org
- Date: Fri, 16 Dec 2016 23:24:24 -0800
- Subject: Re: [PATCH 00/11] Improve generic string routines
- Authentication-results: sourceware.org; auth=none
- References: <20161217065729.28561-1-rth@twiddle.net>
On 12/16/2016 10:57 PM, Richard Henderson wrote:
I'll note that the comments regarding these tests are in fact out
of date -- they speak of a number 0x7efefeff which does not appear
(we use -0x01010101 or 0xfefefeff), and a test misfire which cannot
actually occur (presumably because we changed algorithms).
Hmph. So, this comment really only applies to strlen and memchr.
Upon more rigorous examination, there appear to be three variants in use, one
of which does use 0x7efefeff, and two of which do have the misfire problem.
So the other benefit is that we unify everything to the same, better, algorithm.
r~