This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2 3/5] manual: Add new header and standards annotations.
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Rical Jasan <ricaljasan at pacific dot net>
- Cc: <libc-alpha at sourceware dot org>, <mtk dot manpages at gmail dot com>, <carlos at redhat dot com>
- Date: Wed, 7 Dec 2016 16:31:54 +0000
- Subject: Re: [PATCH v2 3/5] manual: Add new header and standards annotations.
- Authentication-results: sourceware.org; auth=none
- References: <20161206105525.21117-1-ricaljasan@pacific.net> <20161206105525.21117-4-ricaljasan@pacific.net>
On Tue, 6 Dec 2016, Rical Jasan wrote:
> diff --git a/manual/argp.texi b/manual/argp.texi
> index bca3ca5..f1767cc 100644
> --- a/manual/argp.texi
> +++ b/manual/argp.texi
All the changes to this file are OK.
> diff --git a/manual/arith.texi b/manual/arith.texi
> index 0c182c5..eee9880 100644
> --- a/manual/arith.texi
> +++ b/manual/arith.texi
All the changes to this file are OK. Note for when making annotations
more consistent in standard naming in future that:
> @@ -714,7 +724,11 @@ such as by defining @code{_GNU_SOURCE}, and then you must include
> @comment math.h
> @comment ISO
> @deftypevr Macro float SNANF
> +@comment math.h
> +@comment TS 18661-1:2014
> @deftypevrx Macro double SNAN
> +@comment math.h
> +@comment TS 18661-1:2014
> @deftypevrx Macro {long double} SNANL
All three are TS 18661-1:2014.
> @@ -2041,8 +2055,10 @@ NaN.
> @comment math.h
> @comment ISO
> @deftypefun int totalorder (double @var{x}, double @var{y})
> +@comment math.h
> @comment ISO
> @deftypefunx int totalorderf (float @var{x}, float @var{y})
> +@comment math.h
> @comment ISO
> @deftypefunx int totalorderl (long double @var{x}, long double @var{y})
> @safety{@prelim{}@mtsafe{}@assafe{}@acsafe{}}
> @@ -2063,8 +2079,10 @@ payload.
> @comment math.h
> @comment ISO
> @deftypefun int totalordermag (double @var{x}, double @var{y})
> +@comment math.h
> @comment ISO
> @deftypefunx int totalordermagf (float @var{x}, float @var{y})
> +@comment math.h
> @comment ISO
> @deftypefunx int totalordermagl (long double @var{x}, long double @var{y})
As are all these.
> diff --git a/manual/lang.texi b/manual/lang.texi
> index 6281840..5e4d1d3 100644
> --- a/manual/lang.texi
> +++ b/manual/lang.texi
All the changes to this file are OK apart from the question of whether to
document __va_copy at all.
> diff --git a/manual/string.texi b/manual/string.texi
> index 1986357..683a20f 100644
> --- a/manual/string.texi
> +++ b/manual/string.texi
All the changes to this file are OK.
I think the approved pieces should be committed to reduce the size of the
patch in future revisions.
--
Joseph S. Myers
joseph@codesourcery.com