This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/2] Enable ILP32 mode on aarch64, update abilist files
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Steve Ellcey <sellcey at caviumnetworks dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Wed, 30 Nov 2016 00:12:32 +0000
- Subject: Re: [PATCH 1/2] Enable ILP32 mode on aarch64, update abilist files
- Authentication-results: sourceware.org; auth=none
- References: <1480445388.14808.16.camel@caviumnetworks.com>
Please go through all the previous review comments on previous iterations
of ILP32 support (back to 2014) and make sure they are addressed. Some
haven't been.
New comment: please include an addition of ILP32 builds, both LE and BE,
to build-many-glibcs.py.
Possibly new comment: basing on top of Adhemerval's sysvipc consolidation
<https://sourceware.org/ml/libc-alpha/2016-11/msg00284.html> would be
better than adding new versions of various sysvipc files (if you think you
still need new versions after that patch, you need to work with Adhemerval
on making it more general).
Examples of old comments, not necessarily exhaustive: use 10.0.0 as
arch_minimum_kernel until the required changes are actually in Linus's
tree; descriptive comments before copyright notices on each new C file;
GLIBC_2.25 as minimum symbol version (or GLIBC_2.26 if it doesn't get in
within the next month).
Also make sure comments at top of source files are accurate; if you copied
a sysdeps/gnu file, don't keep the "GNU version." description, make it
reflect how it's now AArch64-specific.
--
Joseph S. Myers
joseph@codesourcery.com