This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Remove cached PID/TID in clone
On 15/11/2016 12:29, Florian Weimer wrote:
> On 11/15/2016 03:26 PM, Adhemerval Zanella wrote:
>> On 09/11/2016 10:18, Florian Weimer wrote:
>>>
>>> I really think we should document the clone system call wrapper and spell out these requirements, but that's a separate matter.
>>>
>>
>> Right, I think we can update documentation after patch is upstream.
>
> Agreed.
>
>> I also did a full check on aarch64, powerpc64le, and armhf. I also did
>> some basic tests (basically the posix and nptl one involving clone/fork)
>> on a simulated sparc{64} and mips{64} machine to check if I missed
>> something in clone/vfork assembly changes.
>
> I'm happy with the patch as-is. I'd suggest to wait another week to see if the architecture maintainers have further comments and if not, check it in.
I has been about a week and no architecture maintainer chimed in. I
will commit it shortly.
As before, I rebased and I ran a full make check on x86_64, x32, i686,
armhf, aarch64, and powerpc64le. I also checked some basic tests on
sparc{32,64} and mips{32,64} on a simulated system.
So it would require further testing on alpha, hppa, ia64, m68k, nios2,
s390, sh, and tile (I excluded microblaze because it is already
implementing the patch semantic regarding clone/vfork).