This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix for [f]statfs64/[f]statfs aliasing patch
- From: Andreas Schwab <schwab at suse dot de>
- To: Steve Ellcey <sellcey at caviumnetworks dot com>
- Cc: <libc-alpha at sourceware dot org>, Joseph Myers <joseph at codesourcery dot com>
- Date: Thu, 24 Nov 2016 09:53:30 +0100
- Subject: Re: [PATCH] Fix for [f]statfs64/[f]statfs aliasing patch
- Authentication-results: sourceware.org; auth=none
- References: <1479925292.14643.34.camel@caviumnetworks.com>
On Nov 23 2016, Steve Ellcey <sellcey@caviumnetworks.com> wrote:
> This patch fixes the problem by only hiding the [f]statfs definitions if
> STATFS_IS_STATFS64 is set to non-zero, which is also the only time we do the
> aliasing. To do this I had to change the order of the includes because we
> cannot check STATFS_IS_STATFS64 until after we have included kernel_stat.h
> but we must do it before including sys/stat.h which is where the [f]statfs
> prototypes are defined.
A simpler approach would probably be to move the #undef up directly
after the include.
Ok either way.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."