This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2] Remove defines to builtins in string2.h

On 11/22/2016 05:34 PM, Wilco Dijkstra wrote:

Florian Weimer wrote:

Please remove the definition of _HAVE_STRING_ARCH_strchr as well (from
sysdeps/x86/bits/string.h).


Sure I'll have a quick hunt for dead defines. There must be quite a few by now...


Thanks.


I'm surprised to see stpcpy in this patch because the first paragraph
says this change is exclusively about C90 functions, and stpcpy isn't one.


Joseph's reply to my question made it clear the redirection is done elsewhere
in most cases, so that means we can remove the redirections of non-C90
symbols from string2.h as well:


Also other headers already ensure (most) non-C90 symbols
are redirected to avoid name space clashes.


Ah, I found the reference to C90 symbols confusing.

Florian
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]