This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Partial ILP32 support for aarch64
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Steve Ellcey <sellcey at caviumnetworks dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Mon, 21 Nov 2016 16:51:17 +0000
- Subject: Re: [PATCH] Partial ILP32 support for aarch64
- Authentication-results: sourceware.org; auth=none
- References: <1479515990.908.96.camel@caviumnetworks.com>
On Fri, 18 Nov 2016, Steve Ellcey wrote:
> diff --git a/sysdeps/aarch64/nptl/bits/semaphore.h b/sysdeps/aarch64/nptl/bits/semaphore.h
> index 3cc5b37..1d1389c 100644
> --- a/sysdeps/aarch64/nptl/bits/semaphore.h
> +++ b/sysdeps/aarch64/nptl/bits/semaphore.h
> @@ -21,7 +21,11 @@
> #endif
>
>
> +#ifdef __ILP32__
> +#define __SIZEOF_SEM_T 16
> +#else
> #define __SIZEOF_SEM_T 32
> +#endif
Missing preprocessor indentation inside #ifdef, should be "# define" in
both branches of the #ifdef.
> diff --git a/sysdeps/unix/sysv/linux/aarch64/dl-cache.h b/sysdeps/unix/sysv/linux/aarch64/dl-cache.h
> index 9c7b271..044fdba 100644
> --- a/sysdeps/unix/sysv/linux/aarch64/dl-cache.h
> +++ b/sysdeps/unix/sysv/linux/aarch64/dl-cache.h
> @@ -18,7 +18,11 @@
>
> #include <ldconfig.h>
>
> +#ifdef __LP64__
> #define _DL_CACHE_DEFAULT_ID (FLAG_AARCH64_LIB64 | FLAG_ELF_LIBC6)
> +#else
> +#define _DL_CACHE_DEFAULT_ID (FLAG_AARCH64_LIB32 | FLAG_ELF_LIBC6)
> +#endif
Likewise.
--
Joseph S. Myers
joseph@codesourcery.com