This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/6] New internal function __access_noerrno
On Thursday 10 November 2016 05:44 PM, Adhemerval Zanella wrote:
> In this branch [1] I have a WIP for this. First patch basically
> consolidates access Linux implementation and it uses the strategy
> to check for __NR_access first (and since it on sysdeps/.../linux
> it should not worry about __SYS_*).
Ahh, you meant sysdeps/unix/sysv/linux, I thought you meant
sysdeps/unix. Yes, that makes sense. Can you please post that on the
list for review?
> Second one is the __access_errno implementation. It basically handles
> the 3 cases (hurd, nacl, and Linux) by adding the __access_errno on
> access.c.
>
> I think it should a cleaner solution to __access_noerro (less macro
> handling and build objects).
Sure, I don't mind this kind of implementation either. Do you want to
post this one for review too?
Thanks,
Siddhesh