This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] malloc: Implement heap protector
- From: Andreas Schwab <schwab at suse dot de>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: Paul Eggert <eggert at cs dot ucla dot edu>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Tue, 08 Nov 2016 17:08:59 +0100
- Subject: Re: [PATCH] malloc: Implement heap protector
- Authentication-results: sourceware.org; auth=none
- References: <dd818b8d-7176-8490-0780-e6e25756323a@redhat.com> <7b7d32d4-b66c-4b87-9509-a9ed4df62b85@cs.ucla.edu> <296af8bd-17ab-439e-90d1-bfadf3684c7f@redhat.com>
On Nov 08 2016, Florian Weimer <fweimer@redhat.com> wrote:
>>> +#define set_foot(p, s) \
>>> + (((mchunkptr) ((char *) (p) + (s)))->mchunk_prev_size \
>>> + = HEAP_CRYPT_PREVSIZE (s))
>>
>> Last line is indented one space too much.
>
> I don't have firm opinion on this one. In general, operators on continued
> lines are indented by two spaces.
Continuned lines are not indented relative to the containing expression.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."