This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2 12/16] Use shmat syscall for Linux implementation


On 07/11/2016 09:02, Arnd Bergmann wrote:
> On Wednesday, November 2, 2016 5:26:49 PM CET Adhemerval Zanella wrote:
>> @@ -31,17 +28,19 @@
>>  void *
>>  shmat (int shmid, const void *shmaddr, int shmflg)
>>  {
>> +#ifdef __ASSUME_SYSVIPC_SYSCALL
>> +  return INLINE_SYSCALL_CALL (shmat, shmid, shmaddr, shmflg);
>> +#else
>>    INTERNAL_SYSCALL_DECL(err);
>>    unsigned long resultvar;
>>    void *raddr;
>>
> 
> I looked at the cross-reference for system call tables and found
> that alpha does not define __NR_shmat but instead has __NR_osf_shmat
> 
> Will that get handled correctly by your code?
> 
> 	Arnd

No, but at least it does not prevent alpha build since it uses
the syscalls.list instead.  However adjusting it should be simple,
it would be something like __NR_fadvise64_64 for arm (where it
should be __NR_arm_fadvise64_64 and it is handled on
kernel-features.h).

I tried to avoid remove the syscalls.list usage for architecture
that is already using it, but thinking twice for consolidation idea
it would be better to have all architecture to use only a simple
syscall generation mechanism for a syscall. I will add it on the
patch and send a v3.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]