This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v4] Fix -Os related build and test failures.
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Joseph Myers <joseph at codesourcery dot com>, Andreas Schwab <schwab at linux-m68k dot org>
- Cc: Florian Weimer <fweimer at redhat dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Wed, 2 Nov 2016 09:22:06 -0400
- Subject: Re: [PATCH v4] Fix -Os related build and test failures.
- Authentication-results: sourceware.org; auth=none
- References: <6eac682f-26fa-6a47-9497-357206266ba1@redhat.com> <6be7dce5-bfa7-32c7-5bac-6c3b79776683@redhat.com> <alpine.DEB.2.20.1610281248260.32491@digraph.polyomino.org.uk> <38a493b5-e73f-1bf8-46f0-4121e547a05d@redhat.com> <2ff34c0c-7571-4198-890a-2b30dd7d2920@redhat.com> <5379c2f2-74e6-2550-8d42-2d41d1f6478d@redhat.com> <alpine.DEB.2.20.1610281413340.7606@digraph.polyomino.org.uk> <db9cd7c1-1f32-8fc9-873d-f13bf563a301@redhat.com> <alpine.DEB.2.20.1610291734390.11193@digraph.polyomino.org.uk> <428b3741-9228-68f3-76ec-d042e4075ded@redhat.com> <87mvhjwod1.fsf@linux-m68k.org> <alpine.DEB.2.20.1611011111500.28612@digraph.polyomino.org.uk>
On 11/01/2016 07:12 AM, Joseph Myers wrote:
> On Tue, 1 Nov 2016, Andreas Schwab wrote:
>
>> On Okt 30 2016, Carlos O'Donell <carlos@redhat.com> wrote:
>>
>>> diff --git a/resolv/res_send.c b/resolv/res_send.c
>>> index 6d46bb2..4ec8c1a 100644
>>> --- a/resolv/res_send.c
>>> +++ b/resolv/res_send.c
>>> @@ -664,7 +664,7 @@ send_vc(res_state statp,
>>> a false-positive.
>>> */
>>> DIAG_PUSH_NEEDS_COMMENT;
>>> - DIAG_IGNORE_NEEDS_COMMENT (5, "-Wmaybe-uninitialized");
>>> + DIAG_IGNORE_Os_NEEDS_COMMENT (5, "-Wmaybe-uninitialized");
>>> int resplen;
>>> DIAG_POP_NEEDS_COMMENT;
>>> struct iovec iov[4];
>>
>> That breaks powerpc and s390.
>>
>> res_send.c: In function 'send_vc':
>> res_send.c:668:6: error: 'resplen' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>> int resplen;
>> ^~~~~~~
>
> And the other change to the same file introduces a new use of
> DIAG_IGNORE_NEEDS_COMMENT with a comment that only mentions -Os. Was the
> intent to edit the latter use to be DIAG_IGNORE_Os_NEEDS_COMMENT, with the
> former one edited by mistake instead?
It was indeed a mistake. I used a script to find and fix the uses I'd added,
but here I made a mistake.
I'm running a rawhide build check here to verify the fix fixes things for
x86, x86_64, aarch64, arm, ppc64, ppc64le, and s390.
Cheers,
Carlos.