This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v3] Fix -Os related build and test failures.
- From: Steve Ellcey <sellcey at caviumnetworks dot com>
- To: Carlos O'Donell <carlos at redhat dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Mon, 31 Oct 2016 11:38:26 -0700
- Subject: Re: [PATCH v3] Fix -Os related build and test failures.
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Steve dot Ellcey at cavium dot com;
- References: <db9cd7c1-1f32-8fc9-873d-f13bf563a301@redhat.com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
Carlos,
I am running into a build problem with your patch. weight.h uses the
DIAG_* macros but does not include libc-internal.h, where those macros
are defined. Apparently it assuming whatever file includes it will
include libc-internal.h.
That is not happening for me when I compile
string/strxfrm_l.c, posix/fnmatch.c, and posix/regex.c. regex.c does
not include weight.h itself but includes regex_internal.h which
includes weight.h). I think there are more files with this problem
too, I haven't finished my build yet.
I am building on an aarch64 machine with a prerelease version of GCC
7.0, I think the compiler I am using may be why other people are not
seeing this error.
I am not sure if weight.h should include libc-internal.h, since that is
what uses it, or if the .c and .h files that include weight.h should
also have include libc-internal.h.
Steve Ellcey
sellcey@caviumnetworks.com