Re: [PATCH] Fix i486 builds with gcc 5.3

[Carlos O'Donell <carlos at redhat dot com>]

On 10/27/2016 04:30 PM, Joseph Myers wrote:
> On Thu, 27 Oct 2016, Carlos O'Donell wrote:
> 
>> I have specifically chosen to narrow down the warning suppression to
>> gcc 5.3 because I'm not sure exactly how wide-spread the warnings is and
>> I'd rather be conservative. Others who run into the same error can expand
>> the case to gcc 5 if we see a pattern of failures.
> 
> The version number in DIAG_IGNORE_NEEDS_COMMENT is not a restriction on 
> where the warning is suppressed, it's for documentation purposes only, the 
> most recent version known to need the suppression (so any such calls 
> naming a version older than the oldest now supported for building glibc 
> are appropriate for review to see if they are still needed).
 
Thanks. I mis-remembered that we did something with that number.

I'm going to drop this patch in favour of another one that actually fixes
all the issues compiling with -Os (unrelated to i486).

-- 
Cheers,
Carlos.