This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Initialise the machine specific part of rtld bootstrap map
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Matthew Fortune <Matthew dot Fortune at imgtec dot com>
- Cc: "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>, "Sandra Loosemore (sandra at codesourcery dot com)" <sandra at codesourcery dot com>, Petar Jovanovic <Petar dot Jovanovic at imgtec dot com>
- Date: Wed, 26 Oct 2016 20:11:46 +0000
- Subject: Re: [PATCH] Initialise the machine specific part of rtld bootstrap map
- Authentication-results: sourceware.org; auth=none
- References: <6D39441BF12EF246A7ABCE6654B0235380AABFF9@HHMAIL01.hh.imgtec.org>
On Wed, 26 Oct 2016, Matthew Fortune wrote:
> +# ifdef ELF_MACHINE_INIT_MAP
> + ELF_MACHINE_INIT_MAP (bootstrap_map);
> +# endif
We don't encourage use of #ifdef like that. It's better to have an inline
function defined everywhere and used unconditionally, for which most
systems have a dummy definition (see dl-machine-reject-phdr.h and
elf_machine_reject_phdr_p for an example - if you have a header for a
single function, you don't need to update lots of dl-machine.h headers,
just add a generic version - which has the comments detailing the
semantics of the function and when it's needed - and a MIPS version).
--
Joseph S. Myers
joseph@codesourcery.com