This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] Linux: consolidate rename()
- From: Yury Norov <ynorov at caviumnetworks dot com>
- To: Andreas Schwab <schwab at linux-m68k dot org>
- Cc: <libc-alpha at sourceware dot org>, <zackw at panix dot com>, <arnd at arndb dot de>
- Date: Thu, 20 Oct 2016 14:23:31 +0300
- Subject: Re: [PATCH v2] Linux: consolidate rename()
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Yuri dot Norov at caviumnetworks dot com;
- References: <1476924756-31448-1-git-send-email-ynorov@caviumnetworks.com> <mvminsno5qf.fsf@hawking.suse.de>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
Hi Andreas,
On Thu, Oct 20, 2016 at 09:10:48AM +0200, Andreas Schwab wrote:
> On Okt 20 2016, Yury Norov <ynorov@caviumnetworks.com> wrote:
>
> > diff --git a/sysdeps/unix/sysv/linux/rename.c b/sysdeps/unix/sysv/linux/rename.c
> > new file mode 100644
> > index 0000000..8e14d7d
> > --- /dev/null
> > +++ b/sysdeps/unix/sysv/linux/rename.c
>
> This overrides the unix/syscalls.list entry, thus architectures which
> implement the rename syscall no longer use it.
Yes. You want me to notice it in commit message?
> > @@ -0,0 +1,27 @@
> > +/* rename() implemantation.
> > + Copyright (C) 2016 Free Software Foundation, Inc.
> > + This file is part of the GNU C Library.
> > + Contributed by Chris Metcalf <cmetcalf@tilera.com>, 2011.
> > +
> > + The GNU C Library is free software; you can redistribute it and/or
> > + modify it under the terms of the GNU Lesser General Public
> > + License as published by the Free Software Foundation; either
> > + version 2.1 of the License, or (at your option) any later version.
> > +
> > + The GNU C Library is distributed in the hope that it will be useful,
> > + but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> > + Lesser General Public License for more details.
> > +
> > + You should have received a copy of the GNU Lesser General Public
> > + License along with the GNU C Library. If not, see
> > + <http://www.gnu.org/licenses/>. */
> > +
> > +#include <fcntl.h>
> > +
> > +/* Rename the file OLD to NEW. */
> > +int
> > +rename (const char *old, const char *new)
> > +{
> > + return renameat (AT_FDCWD, old, AT_FDCWD, new);
> > +}
>
> ../sysdeps/unix/sysv/linux/rename.c: In function ‘rename’:
> ../sysdeps/unix/sysv/linux/rename.c:26:3: error: implicit declaration of function ‘renameat’ [-Werror=implicit-function-declaration]
> return renameat (AT_FDCWD, old, AT_FDCWD, new);
> ^
Yes. The file should #inclide <stdio.h> to fix it. If no other issues,
I'll send v3 soon.
Yury