This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v3 9/9] Use libc_ifunc macro for siglongjmp, longjmp in libpthread.

From: Florian Weimer <fweimer at redhat dot com>
To: Stefan Liebler <stli at linux dot vnet dot ibm dot com>, libc-alpha at sourceware dot org
Cc: murphyp at linux dot vnet dot ibm dot com, schwab at linux-m68k dot org, joseph_myers at mentor dot com
Date: Thu, 6 Oct 2016 13:59:13 +0200
Subject: Re: [PATCH v3 9/9] Use libc_ifunc macro for siglongjmp, longjmp in libpthread.
Authentication-results: sourceware.org; auth=none
References: <1472047472-30307-1-git-send-email-stli@linux.vnet.ibm.com> <1472047472-30307-9-git-send-email-stli@linux.vnet.ibm.com>

On 08/24/2016 04:04 PM, Stefan Liebler wrote:

This patch uses the libc_ifunc macro to create already existing ifunc functions
longjmp_ifunc, siglongjmp_ifunc if HAVE_IFUNC is defined.
The s390 pt-longjmp.c includes the common pt-longjmp.c and uses strong_alias
to create the longjmp, siglongjmp symbols for glibc version 2.19.

ChangeLog:

	* nptl/pt-longjmp.c (DEFINE_LONGJMP): Use libc_ifunc macro.
	* sysdeps/unix/sysv/linux/s390/pt-longjmp.c (longjmp, siglongjmp):
	Use strong_alias to create symbols for glibc verison 2.19.


This is okay for now.

Once this is in, I'm going to submit a patch which replaces the IFUNCresolver with a direct call (similar to what we did for fork) because ofthe relocation ordering issue that can cause those IFUNC resolvers to gowrong.


Thanks,
Florian

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]