This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 07/13] Installed-header hygiene (BZ#20366): stack_t.

On 08/29/2016 09:16 PM, Zack Weinberg wrote:
> This is long and repetitive because it touches a whole bunch of
> sysdeps headers.
> sys/ucontext.h unconditionally uses stack_t, and it does not make
> sense to change that.  But signal.h only declares stack_t under
> __USE_XOPEN_EXTENDED || __USE_XOPEN2K8.  The actual definition is already
> in a bits header, bits/sigstack.h, but that header insists on only being
> included by signal.h, so we have to change that as well as all of the
> sys/ucontext.h variants.  (Some but not all variants of bits/sigcontext.h,
> which sys/ucontext.h may also need, had already received this adjustment;
> for consistency, I made them all the same, even if that's not strictly
> necessary in some configurations.)  bits/sigcontext.h and bits/sigstack.h
> also all need to receive multiple inclusion guards (why were we being
> sloppy about that?)

LGTM. This is a good looking cleanup.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]