This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 09/13] Installed-header hygiene (BZ#20366): struct ifreq.


On 08/29/2016 09:16 PM, Zack Weinberg wrote:
> It's unclear to me whether this is the right change, or whether
> instead net/if.h's definition of struct ifreq should be unconditional.
> This has the smaller set of side effects.
> 
> net/if_ppp.h declares itself to be imported from an external source,
> but that last happened in 1996 so I think it's probably a dead letter.
> 
> The Linux and Hurd versions of this file are identical, perhaps
> they should be un-sysdep-ified.
> 
> 	* sysdeps/mach/hurd/net/if_ppp.h
> 	* sysdeps/unix/sysv/linux/net/if_ppp.h:
>         Only define struct ifpppstatsreq and struct ifpppcstatsreq
>         if __USE_MISC is defined.

LGTM.

Please be aware that the Linux kernel may have definitions for some
of these structures (it doesn't for this one, I checked) which conflict.
The way we fix this is via coordinated header inclusion guards, but
the kernel is ahead of us and not coordinating on libc-alpha. If we 
change the include guards, there might be similar changes required in
linux/include/uapi/linux/libc-compat.h.

-- 
Cheers,
Carlos.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]