This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH 03/13] Installed-header hygiene (BZ#20366): missing inclusions A.
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Zack Weinberg <zackw at panix dot com>, Joseph Myers <joseph at codesourcery dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Wed, 21 Sep 2016 13:54:00 -0400
- Subject: Re: [PATCH 03/13] Installed-header hygiene (BZ#20366): missing inclusions A.
- Authentication-results: sourceware.org; auth=none
- References: <email@example.com> <firstname.lastname@example.org> <email@example.com> <firstname.lastname@example.org> <alpine.DEB.email@example.com> <CAKCAbMhur-s2y4+w_X4ttOKQm2JfcunbYOz_TLXvoaM4qWMeJQ@mail.gmail.com>
On 08/29/2016 11:11 PM, Zack Weinberg wrote:
> On Mon, Aug 29, 2016 at 9:23 PM, Joseph Myers <firstname.lastname@example.org> wrote:
>> On Mon, 29 Aug 2016, Zack Weinberg wrote:
>>> These are all fallout from the change from u_intNN_t to uintNN_t; a
>>> number of headers now need to include <stdint.h> to pick up those
>>> types. It is possible that __uintNN_t should be used instead.
>> I'm not clear whether this is needed to restore the glibc build /
>> testsuite build, or only for installed use. If it's needed to keep things
>> building, it has to come *before* the patch that causes the header to be
>> required, to keep bisectability.
> It is necessary to restore the build. This is only separate for ease
> of review; my plan was always to squash the entire series into one big
> patch for landing. Or maybe two or three big patches - the time.h and
> ucontext.h changes qualify as separate ideas, probably.
That was my understanding. That this is going to be a single patch that does
the mechanical changes in one commit which can be reverted, as suggested in