This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 03/13] Installed-header hygiene (BZ#20366): missing inclusions A.


On 08/29/2016 11:11 PM, Zack Weinberg wrote:
> On Mon, Aug 29, 2016 at 9:23 PM, Joseph Myers <joseph@codesourcery.com> wrote:
>> On Mon, 29 Aug 2016, Zack Weinberg wrote:
>>
>>> These are all fallout from the change from u_intNN_t to uintNN_t; a
>>> number of headers now need to include <stdint.h> to pick up those
>>> types.  It is possible that __uintNN_t should be used instead.
>>
>> I'm not clear whether this is needed to restore the glibc build /
>> testsuite build, or only for installed use.  If it's needed to keep things
>> building, it has to come *before* the patch that causes the header to be
>> required, to keep bisectability.
> 
> It is necessary to restore the build.  This is only separate for ease
> of review; my plan was always to squash the entire series into one big
> patch for landing.  Or maybe two or three big patches - the time.h and
> ucontext.h changes qualify as separate ideas, probably.

That was my understanding. That this is going to be a single patch that does
the mechanical changes in one commit which can be reverted, as suggested in
patch 00/13.

-- 
Cheers,
Carlos.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]