This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] struct stat: don't typecast to struct kernel_stat were not needed
On Tue, Sep 06, 2016 at 12:35:41PM -0400, Chris Metcalf wrote:
> On 9/6/2016 12:26 PM, Yury Norov wrote:
> >On Tue, Sep 06, 2016 at 12:19:12PM -0400, Chris Metcalf wrote:
> >>On 9/6/2016 7:28 AM, Yury Norov wrote:
> >>>The cast comes from the beginning of the git history, and probably was needed
> >>>when macro CHECK1() was used in syscalls. Now the cast is looking useless, and
> >>>breaks build if struct kernel_stat is not declared.
> >>>
> >>> * sysdeps/unix/sysv/linux/fxstat.c: Remove useless cast.
> >>> * sysdeps/unix/sysv/linux/lxstat.c: Likewise.
> >>> * sysdeps/unix/sysv/linux/xstat.c: Likewise.
> >>> * sysdeps/unix/sysv/linux/i386/fxstat.c: Likewise.
> >>> * sysdeps/unix/sysv/linux/i386/lxstat.c: Likewise.
> >>> * sysdeps/unix/sysv/linux/i386/xstat.c: Likewise.
> >>>
> >>>Signed-off-by: Yury Norov<ynorov@caviumnetworks.com>
> >>I think you mean "where not needed" in the commit subject.
> >Yes. Should I resend it?
>
> I also notice you are missing a space between your name and your <email address>
> in your Signed-off-by line. That said, Signed-off-by lines are not common in
> glibc repository commits; they are not part of the documented commit process,
> so I would avoid including them in your commits.
>
> I'm not sure who is likely to commit your changes, or if you have commit rights
> yourself, so I'm not sure how to answer as to whether you need to resend it.
No, I have no that rights. Could someone do it to me?
Yury.