This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] fxstatat: fix __fxstatat64 symbol generation
- From: Yury Norov <ynorov at caviumnetworks dot com>
- To: Andreas Schwab <schwab at linux-m68k dot org>
- Cc: <libc-alpha at sourceware dot org>
- Date: Fri, 9 Sep 2016 17:44:34 +0300
- Subject: Re: [PATCH] fxstatat: fix __fxstatat64 symbol generation
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Yuri dot Norov at caviumnetworks dot com;
- References: <1473424150-6407-1-git-send-email-ynorov@caviumnetworks.com> <878tv1p38z.fsf@linux-m68k.org>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On Fri, Sep 09, 2016 at 04:16:44PM +0200, Andreas Schwab wrote:
> On Sep 09 2016, Yury Norov <ynorov@caviumnetworks.com> wrote:
>
> > diff --git a/sysdeps/unix/sysv/linux/fxstatat.c b/sysdeps/unix/sysv/linux/fxstatat.c
> > index f716bf3..32959e5 100644
> > --- a/sysdeps/unix/sysv/linux/fxstatat.c
> > +++ b/sysdeps/unix/sysv/linux/fxstatat.c
> > @@ -61,5 +61,5 @@ libc_hidden_def (__fxstatat)
> > #ifdef XSTAT_IS_XSTAT64
> > # undef __fxstatat64
> > strong_alias (__fxstatat, __fxstatat64);
> > -libc_hidden_def (__fxstatat64)
> > +libc_hidden_ver (__fxstatat, __fxstatat64)
>
> libc_hidden_ver doesn't make sense, as __fxstatat64 isn't a versioned
> symbol. The real problem is that the hidden_proto for __fxstatat64 is
> suppressed.
>
> Andreas.
Maybe. I'm not too experienced in glibc versioning. And what the
correct fix for it?
Yury.