This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] fxstatat: fix __fxstatat64 symbol generation


On Fri, Sep 09, 2016 at 04:16:44PM +0200, Andreas Schwab wrote:
> On Sep 09 2016, Yury Norov <ynorov@caviumnetworks.com> wrote:
> 
> > diff --git a/sysdeps/unix/sysv/linux/fxstatat.c b/sysdeps/unix/sysv/linux/fxstatat.c
> > index f716bf3..32959e5 100644
> > --- a/sysdeps/unix/sysv/linux/fxstatat.c
> > +++ b/sysdeps/unix/sysv/linux/fxstatat.c
> > @@ -61,5 +61,5 @@ libc_hidden_def (__fxstatat)
> >  #ifdef XSTAT_IS_XSTAT64
> >  # undef __fxstatat64
> >  strong_alias (__fxstatat, __fxstatat64);
> > -libc_hidden_def (__fxstatat64)
> > +libc_hidden_ver (__fxstatat, __fxstatat64)
> 
> libc_hidden_ver doesn't make sense, as __fxstatat64 isn't a versioned
> symbol.  The real problem is that the hidden_proto for __fxstatat64 is
> suppressed.
> 
> Andreas.

Maybe. I'm not too experienced in glibc versioning. And what the
correct fix for it?

Yury.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]