This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v3] getrandom system call wrapper [BZ #17252]

On 09/08/2016 05:46 AM, Florian Weimer wrote:
> On 09/08/2016 01:44 PM, Florian Weimer wrote:
>> Here is a new attempt at providing the getrandom system call.
>> I have retained the __getrandom symbol mangling.  The justification for
>> that is that getrandom is a fairly common name.  Application code might
>> use it for something else entirely and interpose their definition, so
>> that libraries cannot rely on it doing the right thing.  I think the
>> mangling is justified because it is hard to spot that getrandom is
>> broken due to interposition.  As <sys/random.h> is a new header, the
>> macro will be exposed to few applications.
>> I have made the system call wrapper a cancellation point.  (If we
>> implement the simpler getentropy interface, it would not be a
>> cancellation point.)
> Updated with Rical's suggestions from the other thread.
> Thanks,
> Florian

Looks good to me!  Thanks for reviewing the review; I agree with all the
things you didn't change too.  :)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]