This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] Add getrandom implementation [BZ #17252]
- From: Florian Weimer <fweimer at redhat dot com>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: Rical Jasan <ricaljasan at pacific dot net>, libc-alpha <libc-alpha at sourceware dot org>
- Date: Thu, 8 Sep 2016 12:27:48 +0200
- Subject: Re: [PATCH v2] Add getrandom implementation [BZ #17252]
- Authentication-results: sourceware.org; auth=none
- References: <88371300-c533-9886-f1de-e34f17f7cbb4@redhat.com> <5774E713.5000907@pacific.net> <700f4f79-2ef1-c34b-2ce9-190e5899fa64@redhat.com> <mvmy432em3i.fsf@hawking.suse.de>
On 09/08/2016 12:12 PM, Andreas Schwab wrote:
+ if (!((flags & GRND_RANDOM)
+ && (flags & GRND_NONBLOCK)
Please add != 0 (no implicit boolean coercion).
The wiki says this is okay (search for “foo & BIT”):
<https://sourceware.org/glibc/wiki/Style_and_Conventions>
Thanks,
Florian