This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[RFC PATCH] __fxstat: replace if() with #if when checking version

__fxstat() is always passed with _STAT_VER as vers parameter and it's
in internal namespace.

It means we can replace runtime argument check with compile-time #ifdef.
It helps to make the body of _fxstat() smaller, and suppresses errors
if struct kernel_stat or __xstat_conv() is not declared, when they
are not needed.

If patch is found reasonable, I can check and fix other platforms and
stat syscalls. Could someone explain me, what for we need 'vers',
if we pass it with the only value everywhere. Maybe it's time to remove it

	* sysdeps/unix/sysv/linux/fxstat.c: Replace if() with #if
	when checking version

Signed-off-by: Yury Norov <>
 sysdeps/unix/sysv/linux/fxstat.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/sysdeps/unix/sysv/linux/fxstat.c b/sysdeps/unix/sysv/linux/fxstat.c
index e33023b..2e79f8b 100644
--- a/sysdeps/unix/sysv/linux/fxstat.c
+++ b/sysdeps/unix/sysv/linux/fxstat.c
@@ -35,20 +35,22 @@
 __fxstat (int vers, int fd, struct stat *buf)
-  if (vers == _STAT_VER_KERNEL)
-    return INLINE_SYSCALL (fstat, 2, fd, buf);
+  return INLINE_SYSCALL (fstat, 2, fd, buf);
+# else
   struct kernel_stat kbuf;
   int result;
   result = INLINE_SYSCALL (fstat, 2, fd, &kbuf);
   if (result == 0)
-    result = __xstat_conv (vers, &kbuf, buf);
+    result = __xstat_conv (_STAT_VER, &kbuf, buf);
   return result;
+# endif

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]