This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] powerpc: fix ifunc-sel.h with GCC 6


Aurelien Jarno <aurelien@aurel32.net> writes:

> On 2016-07-22 13:06, Alan Modra wrote:
>> On Thu, Jul 21, 2016 at 02:48:09PM -0300, Tulio Magno Quites Machado Filho wrote:
>> > Aurelien Jarno <aurelien@aurel32.net> writes:
>> > > 	* sysdeps/powerpc/ifunc-sel.h (ifunc_sel): Replace beqlr instructions
>> > > 	by beq instructions jumping to the end of the function.
>> > 
>> > I'd prefer to remove this file.
>> > 
>> > Alan, do we still need this file?
>> 
>> To do without it, I think you'd need to bump the glibc binutils
>> requirement to 2.24, in order to have this linker fix:
>> https://sourceware.org/ml/binutils/2013-03/msg00299.html

Great!  Thanks!
I run some tests on ppc, ppc64 and ppc64le without this file and I noticed
just one failure from elf/ifuncmain6pie using Binutils 2.26.1 on ppc.
Are there any other requirements to get it working?

> In that case, one possibility is to support ifunc only when the
> installed binutils is at least 2.24. This is basically just changing
> the minimum version in the "Prevent building POWER8 code without support
> in assembler" patch.

In that case and due to the error I mentioned previously, I prefer to carry
this file a little longer with your fix and a source code comment, i.e.:
/* TODO: Remove this file when the minimum required Binutils is 2.24.  The
   following implementation is required when using a linker that doesn't have
   the following fix:
   https://sourceware.org/ml/binutils/2013-03/msg00299.html  */

-- 
Tulio Magno


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]