This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] powerpc: fix ifunc-sel.h with GCC 6


On 2016-07-21 13:53, Florian Weimer wrote:
> On 07/21/2016 11:36 AM, Aurelien Jarno wrote:
> > On 32-bit PowerPC GCC 6 always saves the PIC register on the stack in
> > the prologue and adjust the stack in the epilogue. It is therefore not
> > possible anymore to just exit the function in the inline asm code,
> > otherwise it corrupts the stack pointer. This causes the following tests
> > to fail when using GCC 6:
> 
> >  	   : "=r" (ret)
> >  	   : "X" (&global), "X" (f1), "X" (f2), "X" (f3));
> >    return ret;
> 
> The inline assembly still lacks clobbers for registers 11 and 12, and the
> "X" constraint is incorrect (it should be "i", I think).

I agree that this should be fixed, and I'll try to work on that. That
said it should probably be done as an additional patch, my patch doesn't
touch that part.

Aurelien

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@aurel32.net                 http://www.aurel32.net


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]