This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2.24!] Don't install the internal header grp-merge.h.



On 14/07/2016 22:41, Stephen Gallagher wrote:
> 
> 
>> On Jul 14, 2016, at 4:28 PM, Zack Weinberg <zackw@panix.com> wrote:
>>
>> grp-merge.h was introduced in Stephen Gallagher's patch adding the
>> "group merging" feature to NSS.  It declares two functions, __copy_grp
>> and __merge_grp, both of which are tagged 'internal_function', which
>> means that nobody can even compile the contents of the header without
>> access to libc-symbols.h, which is not installed.  (Also, these
>> functions are GLIBC_PRIVATE exports from libc.so.)  Hence I believe
>> grp-merge.h should not be installed either.
>>
>> This really needs to be in 2.24, so that no released version of the
>> library installs this header.
>>
>> I hope that what I did to the ChangeLog diff will allow it to be
>> applied without hassle.
>>
>> zw
> 
> Sorry, this is indeed a purely internal header and should not be installed. My apologies. Thanks for the patch!

Right, I think this patch should be included in 2.24.  I will commit
it today.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]