This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2.24!] Don't install the internal header grp-merge.h.
- From: Zack Weinberg <zackw at panix dot com>
- To: Stephen Gallagher <sgallagh at redhat dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>, Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- Date: Fri, 15 Jul 2016 07:06:56 -0400
- Subject: Re: [PATCH 2.24!] Don't install the internal header grp-merge.h.
- Authentication-results: sourceware.org; auth=none
- References: <1468528111-4565-1-git-send-email-zackw@panix.com> <13719BA7-71F8-4210-A1C0-656B5B555ECD@redhat.com>
On Thu, Jul 14, 2016 at 9:41 PM, Stephen Gallagher <sgallagh@redhat.com> wrote:
>> On Jul 14, 2016, at 4:28 PM, Zack Weinberg <zackw@panix.com> wrote:
...
>> I believe grp-merge.h should not be installed either.
>>
>> This really needs to be in 2.24, so that no released version of the
>> library installs this header.
>
> Sorry, this is indeed a purely internal header and should not be installed.
> My apologies. Thanks for the patch!
You're welcome. I'm going to need someone to check it in for me.
> One question: will this change cause the header to disappear from the
> tarball? Because we do need it for building.
'make dist' just runs 'git archive', and it's in there:
$ tar tzf ../glibc/glibc-2.23-565-gdbc9ea5.tar.gz | grep grp-merge
glibc-2.23-565-gdbc9ea5/grp/grp-merge.c
glibc-2.23-565-gdbc9ea5/grp/grp-merge.h
glibc-2.23-565-gdbc9ea5/include/grp-merge.h
If this is not the proper way of generating tarballs then I don't know
how to do it.
zw