This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 0/4] Installed-header compilation hygiene, BZ#20366


On Thu, Jul 14, 2016 at 10:25 AM, Adhemerval Zanella
<adhemerval.zanella@linaro.org> wrote:
> On 13/07/2016 21:45, Zack Weinberg wrote:
>> Some of glibc's installed headers throw compilation errors if used in
>> strict standards compliance modes (e.g. -std=c89 with no
>> -D_ANYTHING_SOURCE), or if included without dependencies.  I have a
>> program that tests the installed headers for this class of problems,
>> among other things, and I'd like to propose a batch of corrections for
>> 2.24.  I believe all of these qualify as bugfixes and should be
>> low-risk.
>
> I do see these kind of fixes good fixes, but I think it is too late
> for 2.24.  I would like to move them to 2.25.

Fine by me, except for one thing: grp-merge.h is new this cycle and
really shouldn't be installed (as far as I can tell), please
cherry-pick the change to grp/Makefile for 2.24.

Do you want to get rid of *all* use of u_ types in the installed headers?

zw


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]