This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/2] Add framework for tunables


On Wed, Jul 13, 2016 at 7:49 AM, Siddhesh Poyarekar
<siddhesh@sourceware.org> wrote:
> On Wed, Jul 13, 2016 at 07:43:22AM -0700, H.J. Lu wrote:
>> On x86-64, I got
>>
>> FAIL: malloc/tst-malloc-usable-static-tunables
>> FAIL: malloc/tst-malloc-usable-tunables
>>
>> [hjl@gnu-6 build-x86_64-linux]$ cat malloc/tst-malloc-usable-static-tunables.out
>> malloc_usable_size: expected 7 but got 24
>> [hjl@gnu-6 build-x86_64-linux]$ cat malloc/tst-malloc-usable-tunables.out
>> malloc_usable_size: expected 7 but got 24
>> [hjl@gnu-6 build-x86_64-linux]$
>>
>> I used
>>
>> BUILD_CC="gcc" CC="gcc" CXX="g++" CFLAGS="-O3 -g"
>> /export/gnu/import/git/sources/glibc/configure --prefix=/usr
>> --without-cvs --without-selinux --target=x86_64-linux
>> --build=x86_64-linux --host=x86_64-linux
>> --enable-hardcoded-path-in-tests --enable-large-benchtests
>
> I test on x86_64, so that's odd, maybe due to
> --enable-hardcoded-path-in-tests.  I'll take a look.
>

This scheme doesn't work well for IFUNC.  cpu_features must be
updated very early after init_cpu_features is called.  But __tunables_init
is called too late.  Can it be moved before init_cpu_features so that
cpu_features can be updated at the end of init_cpu_features?

-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]