This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PING][PATCH v9] Add pretty printers for the NPTL lock types


On Tue, Jul 12, 2016 at 10:35:25AM -0300, Martin Galvan wrote:
> Yay for backtracking. I'm concerned about how would we change a
> module's Makefile when we add pretty printers to it.
> tests-need-hardcoded-path would now affect the entire module's tests,
> not just the printer ones, and the rule for testing the printers would
> have to be replicated for each module that has them.

You'll need to create a separate set of rules (and hence, variables,
say, tests-pp) for these tests in Rules.  That way you don't touch the
existing tests framework and you also have a way to completely disable
the rule if your checks for gdb, pexpect, etc. versions fail.

> Besides that, now I have the problem of the tests having to somehow
> find pp_test_common.py, though I could solve that by adding scripts/
> to PYTHONPATH before invoking the tests.

Yes, that is how you would have to solve it.  Look up assignments of
the form *-ENV in malloc/Makefile to see how you can do that.

Siddhesh


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]