This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PING][PATCH v9] Add pretty printers for the NPTL lock types


On Mon, Jul 11, 2016 at 04:54:21PM -0300, Martin Galvan wrote:
> I'm currently looking into discarding .gdbinit and loading the
> printers manually from within the test scripts. Since Roland demanded
> that the printers be scattered among the submodules instead of being
> all placed in the pretty-printers subdir, I now have to figure out
> which submodules actually have printers, and point to those paths
> (yes, I know it's only nptl for now, but I want this to be easily
> extensible). Right now I can't think of any solution that's clean
> enough, so any suggestions are welcome.

Hrm, I guess you could just add a variable with the list of such
modules in the pretty-printers Makefile and then descend into those
directories to make a specific target, but that would be really
clunky.

I think you're better off having the tests in their individual module
directories and have them run as part of that module's tests if
they're supported.  This would mean that the only things in the
pretty-printers directory would be the common file (test_common.py)
and the Makefile (which would now be useless).

So lets do this:

1. Dump the separate directory idea since that's getting too
   convoluted

2. Put the tests in nptl.

3. Move test_common.py into scripts and call it "pp_test_common.py".

4. Move README to toplevel README.pretty-printers

If we ever end up with a significant set of common files for the
pretty printers then we can justify having a separate directory for
them.  I hope this will make things much more straightforward and also
consistent with everything else in glibc.

Siddhesh


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]