This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PING][PATCH v9] Add pretty printers for the NPTL lock types
On Mon, Jul 11, 2016 at 01:11:33PM -0300, Martin Galvan wrote:
> I wasn't aware of versioning issues on PExpect. FWIW I saw that the
> module has a __version__ attribute, so we could set a minimum version
> (4.0.1 maybe?) and mark the tests as UNSUPPORTED if our version is
> lower. It would require a bit of string parsing but it should be
> relatively easy to do.
That is fine too.
> They'd still have to be pushed at the same time, wouldn't they? I
> don't see the point on splitting it unless you're willing to push the
> first version now, and then (after whatever time takes me) the
The splitting makes review easier for me because I won't have to go
through stuff I have already reviewed.
> .gdbinit one, as we were planning to do with the install code. In any
> case, I'd rather have a working, testable version in 2.23 than
> something halfway done.
It's not going to go into 2.23 in this state. The points I stated
above are the minimum criteria for the patch(set) to be acceptable in
distributions.
> As for Stefan's suggestion that this should work with all versions of
> PExpect: that would probably take me a really long time, and I don't
> know if it'd be worth it. While I'm not using most of the features
> PExpect gives you, I'd still have to work around API changes, bugs and
> whatnot.
It is the ideal we ought to aim for, but if it's not doable in the
short term then we'll just have to wait for someone else to enhance
the tests to make them suitable to backport into older releases.
Siddhesh