This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add CFI to x86_64 RTLD_START


Might it make sense to change the macro to clearly
separate the string literals and the backslashes, i.e.

".globl _start\n"                 \
".globl _dl_start_user\n"   \
"_start:\n"                         \

etc.?

On Mon, Jul 4, 2016 at 3:37 PM, Andreas Schwab <schwab@linux-m68k.org> wrote:
> Keno Fischer <keno@juliacomputing.com> writes:
>
>> I should have probably sent this patch with more diff context, but
>> since this is part of a preprocessor `#define`, the backslashes are
>> still required, no?
>
> Yes, sorry, I missed that.  But please put a space before the
> backslashes outside of the string literals.
>
> Andreas.
>
> --
> Andreas Schwab, schwab@linux-m68k.org
> GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
> "And now for something completely different."


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]