This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] S390: Use DT_JUMPREL in prelink undo code.
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Stefan Liebler <stli at linux dot vnet dot ibm dot com>, libc-alpha at sourceware dot org
- Cc: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- Date: Wed, 6 Jul 2016 11:15:44 -0400
- Subject: Re: [PATCH] S390: Use DT_JUMPREL in prelink undo code.
- Authentication-results: sourceware.org; auth=none
- References: <nl3haq$m5v$1@ger.gmane.org> <33a0f109-c782-9840-cce7-a8e259693080@redhat.com> <577D079B.5000005@linux.vnet.ibm.com>
On 07/06/2016 09:28 AM, Stefan Liebler wrote:
> On 07/05/2016 10:17 AM, Florian Weimer wrote:
>> On 06/30/2016 06:28 PM, Stefan Liebler wrote:
>>> * sysdeps/s390/linkmap.h (struct link_map_machine):
>>> Remove member gotplt and add member jmprel.
>>> * sysdeps/s390/s390-32/dl-machine.h
>>> (elf_machine_runtime_setup): Setup member jmprel with DT_JMPREL
>>> instead of gotplt with &got[3].
>>> (elf_machine_lazy_rel): Calculate address with reloc and jmprel.
>>> * sysdeps/s390/s390-64/dl-machine.h: Likewise.
>>
>> I don't see anything obviously wrong with this patch (which doesn't mean
>> much, it's hardly my area of expertise).
>>
>> If you, as one of the architecture maintainers, think this is the right
>> way forward, please commit it.
>>
>> Thanks,
>> Florian
>>
> Okay. I've pushed it and updated release-blockers section in wiki.
>
Thanks for pushing this. This looks good to me.
I reviewed what you did and it makes sense.
--
Cheers,
Carlos.