This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 3/8] i386, x86: Use libc_ifunc macro for time, gettimeofday.
- From: Florian Weimer <fweimer at redhat dot com>
- To: Stefan Liebler <stli at linux dot vnet dot ibm dot com>, libc-alpha at sourceware dot org
- Date: Wed, 6 Jul 2016 13:42:35 +0200
- Subject: Re: [PATCH 3/8] i386, x86: Use libc_ifunc macro for time, gettimeofday.
- Authentication-results: sourceware.org; auth=none
- References: <1466682952-6301-1-git-send-email-stli@linux.vnet.ibm.com> <1466682952-6301-3-git-send-email-stli@linux.vnet.ibm.com> <f04bfe8f-0849-1813-a020-94ddf14c89a4@redhat.com> <nldp95$61e$3@ger.gmane.org>
On 07/04/2016 03:45 PM, Stefan Liebler wrote:
I wonder if it possible to avoid some of the preprocessor magic by
introducing a separate x86_64 file.
Do you mean moving x86/gettimeofday.c to x86_64/gettimeofday.c
and get rid of #include <sysdeps/unix/sysv/linux/x86/gettimeofday.c>?
More like keeping the generic part in x86/gettimeofday.c, and overrides
in i386/gettimeofday.c and x86_64/gettimeofday.c. I was just wondering
if that would be simpler.
I just don't like all these convoluted preprocessor hacks.
Florian