This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 26/27] [AARCH64] Change type of __align to long long
- From: Andreas Schwab <schwab at suse dot de>
- To: "Zhangjian \(Bamvor\)" <bamvor dot zhangjian at huawei dot com>
- Cc: Yury Norov <ynorov at caviumnetworks dot com>, <libc-alpha at sourceware dot org>, <linux-kernel at vger dot kernel dot org>, <arnd at arndb dot de>, <catalin dot marinas at arm dot com>, <marcus dot shawcroft at arm dot com>, <philb at gnu dot org>, <davem at davemloft dot net>, <szabolcs dot nagy at arm dot com>, <maxim dot kuvyrkov at linaro dot org>, <joseph at codesourcery dot com>, <pinskia at gmail dot com>, Andrew Pinski <apinski at cavium dot com>
- Date: Wed, 06 Jul 2016 12:36:40 +0200
- Subject: Re: [PATCH 26/27] [AARCH64] Change type of __align to long long
- Authentication-results: sourceware.org; auth=none
- References: <1466485631-3532-1-git-send-email-ynorov@caviumnetworks.com> <1466485631-3532-28-git-send-email-ynorov@caviumnetworks.com> <57691D91.6080204@huawei.com>
"Zhangjian (Bamvor)" <bamvor.zhangjian@huawei.com> writes:
> Hi, Yury
>
> On 2016/6/21 13:07, Yury Norov wrote:
>> From: Andrew Pinski <apinski@cavium.com>
>>
>> So that ILP32 is aligned to 64bits.
>>
>> Signed-off-by: Yury Norov <ynorov@caviumnetworks.com>
>> ---
>> sysdeps/aarch64/nptl/bits/semaphore.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/sysdeps/aarch64/nptl/bits/semaphore.h b/sysdeps/aarch64/nptl/bits/semaphore.h
>> index 3cc5b37..3fe6047 100644
>> --- a/sysdeps/aarch64/nptl/bits/semaphore.h
>> +++ b/sysdeps/aarch64/nptl/bits/semaphore.h
>> @@ -31,5 +31,5 @@
>> typedef union
>> {
>> char __size[__SIZEOF_SEM_T];
>> - long int __align;
>> + long long int __align;
> Why we need align to 64bit?
Because aarch64 defines __HAVE_64B_ATOMICS.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."