This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix LO_HI_LONG definition
- From: Florian Weimer <fweimer at redhat dot com>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, libc-alpha at sourceware dot org
- Date: Tue, 5 Jul 2016 15:18:54 +0200
- Subject: Re: [PATCH] Fix LO_HI_LONG definition
- Authentication-results: sourceware.org; auth=none
- References: <1467652080-19812-1-git-send-email-adhemerval.zanella@linaro.org>
On 07/04/2016 07:08 PM, Adhemerval Zanella wrote:
The p{read,write}v{64} consolidation patch [1] added a wrong guard
for LO_HI_LONG definition. It currently uses both
'__WORDSIZE == 64' and 'defined __ASSUME_WORDSIZE64_ILP32' to set
the value to be passed in one argument, otherwise it will be split
in two.
However it fails on MIPS64n32 where syscalls n32 uses the compat
implementation in the kernel meaning the off_t arguments are passed
in two separate registers.
Was this bug caught by the glibc test suite on the affected architecture?
Thanks,
Florian