This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH x86_64][BZ #20139] Don't allow configure with not supporting AVX512 assembler w/o --disable-avx512.


On Thu, Jun 30, 2016 at 11:13 PM, Florian Weimer <fweimer@redhat.com> wrote:
> On 06/30/2016 02:23 PM, H.J. Lu wrote:
>>
>> On Thu, Jun 30, 2016 at 4:15 AM, Florian Weimer <fweimer@redhat.com>
>> wrote:
>>>
>>> On 06/29/2016 11:45 PM, H.J. Lu wrote:
>>>>
>>>>
>>>> Subject: [PATCH] Require binutils 2.24 to build x86-64 glibc
>>>
>>>
>>>
>>> Please put [BZ #20139] at the end of the first line.
>>
>>
>> What do you mean by that?  My ChangeLog entries are
>>
>>                  [BZ #20139]
>>                  * config.h.in (HAVE_AVX512_ASM_SUPPORT): Renamed to ...
>>                  (HAVE_AVX512DQ_ASM_SUPPORT): This.
>>
>> It looks normal to me.
>
>
> I meant at the end of the first line of the commit message.

I will do that.

>> Here is the patch with updated commit message, including only disabling
>> the AVX512DQ part of mathvec without AVX512DQ.
>>
>> OK for master?
>
>
> I have no objections to the patch as such (but also see my other comment
> about aligning the XGETBV values with what the dynamic linker supports).
>

Yes, that was a mistake and we should have done that.


-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]