This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [RFC PATCH] AARCH64/ILP32: introduce kernel time types
- From: Yury Norov <ynorov at caviumnetworks dot com>
- To: Szabolcs Nagy <szabolcs dot nagy at arm dot com>
- Cc: Arnd Bergmann <arnd at arndb dot de>, <nd at arm dot com>, <libc-alpha at sourceware dot org>, <vapier at gentoo dot org>, <joseph at codesourcery dot com>, <cmetcalf at tilera dot com>, <pinskia at gmail dot com>, <cmetcalf at mellanox dot com>, <bamvor dot zhangjian at huawei dot com>, <schwab at suse dot de>, <catalin dot marinas at arm dot com>, <fweimer at redhat dot com>, <Prasun dot Kapoor at cavium dot com>, <maxim dot kuvyrkov at linaro dot org>
- Date: Tue, 28 Jun 2016 13:14:38 +0300
- Subject: Re: [RFC PATCH] AARCH64/ILP32: introduce kernel time types
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp dot mailfrom=Yuri dot Norov at caviumnetworks dot com;
- References: <1467103498-24243-1-git-send-email-ynorov at caviumnetworks dot com> <3868455 dot JHxyTqAzNd at wuerfel> <20160628090709 dot GA24462 at yury-N73SV> <5772429E dot 6070008 at arm dot com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On Tue, Jun 28, 2016 at 10:25:50AM +0100, Szabolcs Nagy wrote:
> On 28/06/16 10:07, Yury Norov wrote:
> > This is not about 64-bit time_t. This is about new type __ktime_t that
> > can replace time_t where it's safe.
> >
>
> there is no need to introduce new type names
> see the __WORDSIZE_TIME64_COMPAT32 case.
It does not use time_t at all, but int32_t. I think it's a hack. If
we follow it, affected structures will be overloaded with ifdefs. In
fact, I tried it first, and didn't like what I get. This approach
moves type declaration where it should be, and maintains user-visible
structures simple and clear.
Yury.