This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [RFC v2][PATCH 22/27] Export stack_used as __stack_used
- From: Gary Benson <gbenson at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Mon, 13 Jun 2016 12:23:51 +0100
- Subject: Re: [RFC v2][PATCH 22/27] Export stack_used as __stack_used
- Authentication-results: sourceware.org; auth=none
- References: <1465814311-31470-1-git-send-email-gbenson at redhat dot com> <1465814311-31470-23-git-send-email-gbenson at redhat dot com> <e93cb41f-2b54-576d-dc97-dd0280eaf746 at redhat dot com> <20160613112001 dot GA336 at blade dot nx>
Gary Benson wrote:
> Pedro Alves wrote:
> > BTW, the td_ta_thr_iter.c::iterate_thread_list hunk looks like
> > just a code style change unrelated to the subject of the patch.
>
> It's not a style change, it stops it falling through into the rest
> of the function if next == 0 and !fake_empty.
>
> I agree it should be a separate patch though.
Oh, wait, no, I remember: the reason it's not a separate patch is
that stack_user is statically initialized, so next == 0 never
occurred. But, changing it to __stack_user changed how it has to
be initialized, so next == 0 can now occur.
So it should be the same patch (but maybe it needs documenting!)
Cheers,
Gary
--
http://gbenson.net/