This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] nptl: Add sendmmsg and recvmmsg cancellation tests
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, Joseph Myers <joseph at codesourcery dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Fri, 10 Jun 2016 14:41:57 -0400
- Subject: Re: [PATCH] nptl: Add sendmmsg and recvmmsg cancellation tests
- Authentication-results: sourceware.org; auth=none
- References: <1465571155-18996-1-git-send-email-adhemerval dot zanella at linaro dot org> <alpine dot DEB dot 2 dot 20 dot 1606101702540 dot 721 at digraph dot polyomino dot org dot uk> <C95712DE-8DE4-4B35-808A-8216E7AB839D at linaro dot org> <83704f92-78e4-1585-a88e-df411a0634b1 at redhat dot com> <575B0450 dot 2000803 at linaro dot org>
On 06/10/2016 02:17 PM, Adhemerval Zanella wrote:
>
>
> On 10/06/2016 14:54, Carlos O'Donell wrote:
>> On 06/10/2016 01:46 PM, Adhemerval Zanella wrote:
>>>
>>>
>>>> On Jun 10, 2016, at 14:04, Joseph Myers <joseph@codesourcery.com> wrote:
>>>>
>>>>> On Fri, 10 Jun 2016, Adhemerval Zanella wrote:
>>>>>
>>>>> This patch adds cancellation tests for both sendmmsg and recvmmsg
>>>>> syscalls.
>>>>
>>>> Will these work if those fail with ENOSYS (old kernels, or non-Linux ports
>>>> using NPTL)
>>>
>>> Right, I think best approach the to not fail for ENOSYS with a print
>>> saying it is not supported I the system. I will change that.
>>
>> If the only thing being tested is skipped then you should exit(77)
>> to indicate UNSUPPORTED.
>>
>
> In this case the syscalls tests is used along with some other cancellable
> interfaces. Should I create an specific test just to indicate it?
Probably a good idea.
--
Cheers,
Carlos.