This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] malloc: Correct size computation in realloc for dumped fake mmapped chunks
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Florian Weimer <fweimer at redhat dot com>, libc-alpha at sourceware dot org
- Date: Wed, 8 Jun 2016 16:38:59 -0400
- Subject: Re: [PATCH] malloc: Correct size computation in realloc for dumped fake mmapped chunks
- Authentication-results: sourceware.org; auth=none
- References: <20160608185123 dot BB0D84012CF92 at oldenburg dot str dot redhat dot com>
On 06/08/2016 02:51 PM, Florian Weimer wrote:
> For regular mmapped chunks there are two size fields (hence a reduction
> by 2 * SIZE_SZ bytes), but for fake chunks, we only have one size field,
> so we need to subtract SIZE_SZ bytes.
>
> This was initially reported as Emacs bug 23726.
>
> 2016-06-08 Florian Weimer <fweimer@redhat.com>
>
> Emacs bug 23726.
> * malloc/malloc.c (dumped_main_arena_start): Update comment.
> (__libc_realloc): Correct size computation for dumped fake mmapped
> chunks.
Reviewed the existing mmapped chunk code, and this fix looks good to me.
--
Cheers,
Carlos.