This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 07/14 v6] Prevent the rtld mapfile computation from dragging in __stack_chk_fail*.
- From: Paul Eggert <eggert at cs dot ucla dot edu>
- To: Nix <nix at esperi dot org dot uk>
- Cc: libc-alpha at sourceware dot org, fweimer at redhat dot com
- Date: Tue, 7 Jun 2016 16:35:18 -0700
- Subject: Re: [PATCH 07/14 v6] Prevent the rtld mapfile computation from dragging in __stack_chk_fail*.
- Authentication-results: sourceware.org; auth=none
- References: <1465297576-10981-1-git-send-email-nix at esperi dot org dot uk> <1465297576-10981-8-git-send-email-nix at esperi dot org dot uk> <mvmshwprzxf dot fsf at hawking dot suse dot de> <87lh2hcijc dot fsf at esperi dot org dot uk>
On 06/07/2016 05:03 AM, Nix wrote:
This and one comment in the same
patch (also fixed) are the only places where I overflow lines that are
fixable (configure.ac is more or less not fixable, AIUI).
Why is configure.ac not fixable? E.g., in this patch:
+ AC_HELP_STRING([--enable-stack-protector=@<:@yes|no|all|strong@:>@],
+ [Use -fstack-protector[-all|-strong] to detect glibc buffer overflows]),
The commentary can contain folded lines without problem (the extra indenting is removed), and the first line can be moved down, e.g.,
AC_HELP_STRING(
[--enable-stack-protector=@<:@yes|no|all|strong@:>@],
[Use -fstack-protector[-all|-strong] to detect glibc
buffer overflows]),