This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/2] Consolidate pwritev/pwritev64 implementations
- From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- To: Franz Sirl <Franz dot Sirl-kernel at lauterbach dot com>, libc-alpha at sourceware dot org
- Date: Fri, 3 Jun 2016 10:43:35 -0300
- Subject: Re: [PATCH 2/2] Consolidate pwritev/pwritev64 implementations
- Authentication-results: sourceware.org; auth=none
- References: <1464866792-11025-1-git-send-email-adhemerval dot zanella at linaro dot org> <1464866792-11025-2-git-send-email-adhemerval dot zanella at linaro dot org> <257d7654-1732-dcae-7c42-2f720638cb7c at lauterbach dot com>
On 03/06/2016 04:19, Franz Sirl wrote:
>
>> diff --git a/misc/Makefile b/misc/Makefile
>> index 658d4ba..aab1174 100644
>> --- a/misc/Makefile
>> +++ b/misc/Makefile
>> @@ -90,6 +90,8 @@ CFLAGS-readv.c = -fexceptions -fasynchronous-unwind-tables
>> CFLAGS-writev.c = -fexceptions -fasynchronous-unwind-tables
>> CFLAGS-preadv.c = -fexceptions -fasynchronous-unwind-tables
>> CFLAGS-preadv64.c = -fexceptions -fasynchronous-unwind-tables
>> +CFLAGS-pwritev.c = -fexceptions -fasynchronous-unwind-tables
>> +CFLAGS-pwrite64.c = -fexceptions -fasynchronous-unwind-tables
> ~~~~~~~~~~~~~~~~^^
>
> Typo missing v?
>
> Franz
>
Yes and ideally it should be make the cancellation tests fail on some
platforms I checked (specially on ppc64le). However there is no
cancellation test for preadv/pwritev, so I will add one.