This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Do we care about malloc failure in tests?

From: Alexander Cherepanov <ch3root at openwall dot com>
To: Andreas Schwab <schwab at suse dot de>, Paul Pluzhnikov <ppluzhnikov at google dot com>
Cc: GLIBC Devel <libc-alpha at sourceware dot org>, Bill Parker <wp02855 at gmail dot com>
Date: Tue, 31 May 2016 19:45:59 +0300
Subject: Re: Do we care about malloc failure in tests?
Authentication-results: sourceware.org; auth=none
References: <CALoOobNcJ6MaE3OfhY2KebXa=Z8kzhsgKpoesbzvvhUEEZhz=A at mail dot gmail dot com> <mvmmvn6ya67 dot fsf at hawking dot suse dot de>

On 2016-05-31 10:10, Andreas Schwab wrote:

Paul Pluzhnikov <ppluzhnikov@google.com> writes:

Do we have a policy here?
Should I fix them to consistently check for NULL, or delete existing
NULL checks?


All tests should do proper NULL checks, only to set a good example.

That would be nice. When I was playing with static analysis of glibccode, tests were giving quite some noise. The policy of holding tests tothe same level of rigor as the main code converts this noise into signal:-)


--
Alexander Cherepanov

References:
- Do we care about malloc failure in tests?
  - From: Paul Pluzhnikov
- Re: Do we care about malloc failure in tests?
  - From: Andreas Schwab

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]