This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Make padding in struct sockaddr_storage explicit [BZ #20111]
- From: Andreas Schwab <schwab at suse dot de>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Mon, 23 May 2016 10:07:15 +0200
- Subject: Re: [PATCH] Make padding in struct sockaddr_storage explicit [BZ #20111]
- Authentication-results: sourceware.org; auth=none
- References: <20160519131238 dot 1C38540113D03 at oldenburg dot str dot redhat dot com> <mvm60ua5fpa dot fsf at hawking dot suse dot de> <ba52d849-7100-ffbb-0319-8844a31e11b3 at redhat dot com> <mvm1t4y5b62 dot fsf at hawking dot suse dot de> <ac226de8-b43a-7a1f-547c-b3a1b872ea3e at redhat dot com> <mvmwpmq3ubb dot fsf at hawking dot suse dot de> <ac6a9a34-fb41-6dae-c7b9-ce460af96699 at redhat dot com>
Florian Weimer <fweimer@redhat.com> writes:
> diff --git a/sysdeps/unix/sysv/linux/bits/socket.h b/sysdeps/unix/sysv/linux/bits/socket.h
> index 0581c79..8fbb6be 100644
> --- a/sysdeps/unix/sysv/linux/bits/socket.h
> +++ b/sysdeps/unix/sysv/linux/bits/socket.h
> @@ -158,16 +158,15 @@ struct sockaddr
>
>
> /* Structure large enough to hold any socket address (with the historical
> - exception of AF_UNIX). We reserve 128 bytes. */
> + exception of AF_UNIX). */
> #define __ss_aligntype unsigned long int
> -#define _SS_SIZE 128
> #define _SS_PADSIZE (_SS_SIZE - (2 * sizeof (__ss_aligntype)))
_SS_PADSIZE needs to be updated here as well. Otherwise, looks ok.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."