This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 5/8] Apply LIT(x) to floating point literals in libm-test.c


On Wed, 18 May 2016, Paul E. Murphy wrote:

> +  # If it doesn't have a period or an exponent, its not an FP literal.
> +  if (index ($lit, ".") == -1 and $lit !~ /[pe]([+-])?[0-9]+/) {
> +    return $lit;

This would interpret e.g. 0x1e2 as a floating-point literal.  It looks 
like we don't have such literals in libm-test.inc at present (we do have 
0x1fffffe, which doesn't match your regular expression), but it still 
seems too fragile.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]