This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH 4/5] Refactor tst-strtod-round.c
- From: "Paul E. Murphy" <murphyp at linux dot vnet dot ibm dot com>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Tue, 17 May 2016 11:42:51 -0500
- Subject: Re: [PATCH 4/5] Refactor tst-strtod-round.c
- Authentication-results: sourceware.org; auth=none
- References: <cover dot 1463433826 dot git dot murphyp at linux dot vnet dot ibm dot com> <8968b370018788e6fb7d7249118faa96f2e2ba90 dot 1463433827 dot git dot murphyp at linux dot vnet dot ibm dot com> <alpine dot DEB dot 2 dot 20 dot 1605162242570 dot 12314 at digraph dot polyomino dot org dot uk> <5bdcaff5-b5b1-2dc5-4801-63edbc3e2f81 at linux dot vnet dot ibm dot com> <alpine dot DEB dot 2 dot 20 dot 1605171610360 dot 24255 at digraph dot polyomino dot org dot uk>
On 05/17/2016 11:14 AM, Joseph Myers wrote:
> On Tue, 17 May 2016, Paul E. Murphy wrote:
>>> So far this message has reached the libc-alpha list twice (you don't see
>>> it twice in the archives because it has the same message-id each time).
>>> I've seen this issue before with large messages coming to libc-alpha from
>>> IBM (many duplicate copies of them arrive on the list), as if there is
>>> some problem with IBM's mail server timing out before sourceware accepts
>>> the message, or something like that. Please try to get that mail system
>>> problem fixed.
>> Ugh. Thanks for pointing that out. That is annoying. I'll try.
> It's *also* a good idea to omit large generated file changes from patch
> postings, unless they are important for the review. (When constant
> suffixes are eliminated from auto-libm-test-out - desirable for the same
> reasons as for the present patch - that will rewrite the whole file - a >
> 60MB diff - and you certainly don't want to send that to the list.)
Admittedly, my cutoff for "too big" was still too big. Lesson learned.
Anyhow, for those tests, we do have the opportunity to post-process
the content as part of building the tests. In that (yet to be submitted
to libc-alpha) patchset, I updated gen-libm-test.pl to strip C99 literal
suffixes, then wrap them with a new macro named LIT() to apply the
appropriate suffix depending on the type under test. With the exception
of nexttoward and its long double second argument.