This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Remove x86 ifunc-defines.sym and rtld-global-offsets.sym
- From: Andreas Schwab <schwab at suse dot de>
- To: "H.J. Lu" <hongjiu dot lu at intel dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>, "H.J. Lu" <hjl dot tools at gmail dot com>
- Date: Tue, 10 May 2016 16:03:08 +0200
- Subject: Re: [PATCH] Remove x86 ifunc-defines.sym and rtld-global-offsets.sym
- Authentication-results: sourceware.org; auth=none
- References: <20160510133554 dot GA5665 at intel dot com>
"H.J. Lu" <hongjiu.lu@intel.com> writes:
> diff --git a/sysdeps/x86/cpu-features-offsets.sym b/sysdeps/x86/cpu-features-offsets.sym
> index a9d53d1..f6907e0 100644
> --- a/sysdeps/x86/cpu-features-offsets.sym
> +++ b/sysdeps/x86/cpu-features-offsets.sym
> @@ -1,7 +1,24 @@
> #define SHARED 1
>
> -#include <ldsodefs.h>
> +#include "init-arch.h"
> +#include <stddef.h>
This will find sysdeps/x86/init-arch.h first, doesn't it? I don't know
if MINIMUM_ISA has an effect here, but it appears cleaner to use
<init-arch.h> instead.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."